mirror of
https://github.com/ARM-software/arm-trusted-firmware.git
synced 2025-08-17 18:07:01 +02:00
09d40e0e08
Enforce full include path for includes. Deprecate old paths.
The following folders inside include/lib have been left unchanged:
- include/lib/cpus/${ARCH}
- include/lib/el3_runtime/${ARCH}
The reason for this change is that having a global namespace for
includes isn't a good idea. It defeats one of the advantages of having
folders and it introduces problems that are sometimes subtle (because
you may not know the header you are actually including if there are two
of them).
For example, this patch had to be created because two headers were
called the same way: e0ea0928d5 ("Fix gpio includes of mt8173 platform
to avoid collision."). More recently, this patch has had similar
problems: 46f9b2c3a2 ("drivers: add tzc380 support").
This problem was introduced in commit 4ecca33988 ("Move include and
source files to logical locations"). At that time, there weren't too
many headers so it wasn't a real issue. However, time has shown that
this creates problems.
Platforms that want to preserve the way they include headers may add the
removed paths to PLAT_INCLUDES, but this is discouraged.
Change-Id: I39dc53ed98f9e297a5966e723d1936d6ccf2fc8f
Signed-off-by: Antonio Nino Diaz <antonio.ninodiaz@arm.com>
89 lines
3.0 KiB
C
89 lines
3.0 KiB
C
/*
|
|
* Copyright (c) 2015-2018, ARM Limited and Contributors. All rights reserved.
|
|
*
|
|
* SPDX-License-Identifier: BSD-3-Clause
|
|
*/
|
|
#ifndef COMMON_DEF_H
|
|
#define COMMON_DEF_H
|
|
|
|
#include <platform_def.h>
|
|
|
|
#include <common/bl_common.h>
|
|
#include <lib/utils_def.h>
|
|
#include <lib/xlat_tables/xlat_tables_defs.h>
|
|
|
|
/******************************************************************************
|
|
* Required platform porting definitions that are expected to be common to
|
|
* all platforms
|
|
*****************************************************************************/
|
|
|
|
/*
|
|
* Platform binary types for linking
|
|
*/
|
|
#ifdef AARCH32
|
|
#define PLATFORM_LINKER_FORMAT "elf32-littlearm"
|
|
#define PLATFORM_LINKER_ARCH arm
|
|
#else
|
|
#define PLATFORM_LINKER_FORMAT "elf64-littleaarch64"
|
|
#define PLATFORM_LINKER_ARCH aarch64
|
|
#endif /* AARCH32 */
|
|
|
|
/*
|
|
* Generic platform constants
|
|
*/
|
|
#define FIRMWARE_WELCOME_STR "Booting Trusted Firmware\n"
|
|
|
|
#define BL2_IMAGE_DESC { \
|
|
.image_id = BL2_IMAGE_ID, \
|
|
SET_STATIC_PARAM_HEAD(image_info, PARAM_EP, \
|
|
VERSION_2, image_info_t, 0), \
|
|
.image_info.image_base = BL2_BASE, \
|
|
.image_info.image_max_size = BL2_LIMIT - BL2_BASE,\
|
|
SET_STATIC_PARAM_HEAD(ep_info, PARAM_EP, \
|
|
VERSION_2, entry_point_info_t, SECURE | EXECUTABLE),\
|
|
.ep_info.pc = BL2_BASE, \
|
|
}
|
|
|
|
/*
|
|
* The following constants identify the extents of the code & read-only data
|
|
* regions. These addresses are used by the MMU setup code and therefore they
|
|
* must be page-aligned.
|
|
*
|
|
* When the code and read-only data are mapped as a single atomic section
|
|
* (i.e. when SEPARATE_CODE_AND_RODATA=0) then we treat the whole section as
|
|
* code by specifying the read-only data section as empty.
|
|
*
|
|
* BL1 is different than the other images in the sense that its read-write data
|
|
* originally lives in Trusted ROM and needs to be relocated in Trusted SRAM at
|
|
* run-time. Therefore, the read-write data in ROM can be mapped with the same
|
|
* memory attributes as the read-only data region. For this reason, BL1 uses
|
|
* different macros.
|
|
*
|
|
* Note that BL1_ROM_END is not necessarily aligned on a page boundary as it
|
|
* just points to the end of BL1's actual content in Trusted ROM. Therefore it
|
|
* needs to be rounded up to the next page size in order to map the whole last
|
|
* page of it with the right memory attributes.
|
|
*/
|
|
#if SEPARATE_CODE_AND_RODATA
|
|
|
|
#define BL1_CODE_END BL_CODE_END
|
|
#define BL1_RO_DATA_BASE BL_RO_DATA_BASE
|
|
#define BL1_RO_DATA_END round_up(BL1_ROM_END, PAGE_SIZE)
|
|
#if BL2_IN_XIP_MEM
|
|
#define BL2_CODE_END BL_CODE_END
|
|
#define BL2_RO_DATA_BASE BL_RO_DATA_BASE
|
|
#define BL2_RO_DATA_END round_up(BL2_ROM_END, PAGE_SIZE)
|
|
#endif /* BL2_IN_XIP_MEM */
|
|
#else
|
|
#define BL_RO_DATA_BASE UL(0)
|
|
#define BL_RO_DATA_END UL(0)
|
|
#define BL1_CODE_END round_up(BL1_ROM_END, PAGE_SIZE)
|
|
#if BL2_IN_XIP_MEM
|
|
#define BL2_RO_DATA_BASE UL(0)
|
|
#define BL2_RO_DATA_END UL(0)
|
|
#define BL2_CODE_END round_up(BL2_ROM_END, PAGE_SIZE)
|
|
#endif /* BL2_IN_XIP_MEM */
|
|
#endif /* SEPARATE_CODE_AND_RODATA */
|
|
|
|
#endif /* COMMON_DEF_H */
|