mirror of
https://github.com/ARM-software/arm-trusted-firmware.git
synced 2025-08-15 08:57:02 +02:00
09d40e0e08
Enforce full include path for includes. Deprecate old paths.
The following folders inside include/lib have been left unchanged:
- include/lib/cpus/${ARCH}
- include/lib/el3_runtime/${ARCH}
The reason for this change is that having a global namespace for
includes isn't a good idea. It defeats one of the advantages of having
folders and it introduces problems that are sometimes subtle (because
you may not know the header you are actually including if there are two
of them).
For example, this patch had to be created because two headers were
called the same way: e0ea0928d5 ("Fix gpio includes of mt8173 platform
to avoid collision."). More recently, this patch has had similar
problems: 46f9b2c3a2 ("drivers: add tzc380 support").
This problem was introduced in commit 4ecca33988 ("Move include and
source files to logical locations"). At that time, there weren't too
many headers so it wasn't a real issue. However, time has shown that
this creates problems.
Platforms that want to preserve the way they include headers may add the
removed paths to PLAT_INCLUDES, but this is discouraged.
Change-Id: I39dc53ed98f9e297a5966e723d1936d6ccf2fc8f
Signed-off-by: Antonio Nino Diaz <antonio.ninodiaz@arm.com>
79 lines
1.9 KiB
ArmAsm
79 lines
1.9 KiB
ArmAsm
/*
|
|
* Copyright (c) 2017, ARM Limited and Contributors. All rights reserved.
|
|
*
|
|
* SPDX-License-Identifier: BSD-3-Clause
|
|
*/
|
|
|
|
#ifndef PLAT_MACROS_S
|
|
#define PLAT_MACROS_S
|
|
|
|
#include <drivers/arm/cci.h>
|
|
#include <drivers/arm/gicv2.h>
|
|
#include <hi6220.h>
|
|
#include <platform_def.h>
|
|
|
|
.section .rodata.gic_reg_name, "aS"
|
|
gicc_regs:
|
|
.asciz "gicc_hppir", "gicc_ahppir", "gicc_ctlr", ""
|
|
gicd_pend_reg:
|
|
.asciz "gicd_ispendr regs (Offsets 0x200 - 0x278)\n Offset:\t\t\tvalue\n"
|
|
newline:
|
|
.asciz "\n"
|
|
spacer:
|
|
.asciz ":\t\t0x"
|
|
|
|
.section .rodata.cci_reg_name, "aS"
|
|
cci_iface_regs:
|
|
.asciz "cci_snoop_ctrl_cluster0", "cci_snoop_ctrl_cluster1" , ""
|
|
|
|
/* ---------------------------------------------
|
|
* The below macro prints out relevant GIC
|
|
* registers whenever an unhandled exception is
|
|
* taken in BL31.
|
|
* ---------------------------------------------
|
|
*/
|
|
.macro plat_crash_print_regs
|
|
mov_imm x16, PLAT_ARM_GICD_BASE
|
|
mov_imm x17, PLAT_ARM_GICC_BASE
|
|
|
|
/* Load the gicc reg list to x6 */
|
|
adr x6, gicc_regs
|
|
/* Load the gicc regs to gp regs used by str_in_crash_buf_print */
|
|
ldr w8, [x17, #GICC_HPPIR]
|
|
ldr w9, [x17, #GICC_AHPPIR]
|
|
ldr w10, [x17, #GICC_CTLR]
|
|
/* Store to the crash buf and print to cosole */
|
|
bl str_in_crash_buf_print
|
|
|
|
/* Print the GICD_ISPENDR regs */
|
|
add x7, x16, #GICD_ISPENDR
|
|
adr x4, gicd_pend_reg
|
|
bl asm_print_str
|
|
2:
|
|
sub x4, x7, x16
|
|
cmp x4, #0x280
|
|
b.eq 1f
|
|
bl asm_print_hex
|
|
adr x4, spacer
|
|
bl asm_print_str
|
|
ldr x4, [x7], #8
|
|
bl asm_print_hex
|
|
adr x4, newline
|
|
bl asm_print_str
|
|
b 2b
|
|
1:
|
|
adr x6, cci_iface_regs
|
|
/* Store in x7 the base address of the first interface */
|
|
mov_imm x7, (CCI400_BASE + SLAVE_IFACE_OFFSET( \
|
|
CCI400_SL_IFACE3_CLUSTER_IX))
|
|
ldr w8, [x7, #SNOOP_CTRL_REG]
|
|
/* Store in x7 the base address of the second interface */
|
|
mov_imm x7, (CCI400_BASE + SLAVE_IFACE_OFFSET( \
|
|
CCI400_SL_IFACE4_CLUSTER_IX))
|
|
ldr w9, [x7, #SNOOP_CTRL_REG]
|
|
/* Store to the crash buf and print to console */
|
|
bl str_in_crash_buf_print
|
|
.endm
|
|
|
|
#endif /* PLAT_MACROS_S */
|