From 9694c2104cd247aab0e6462e0bc6acabe808b470 Mon Sep 17 00:00:00 2001 From: Julius Werner Date: Thu, 27 Aug 2020 16:30:44 -0700 Subject: [PATCH] qti: spmi_arb: Fix coverity integer conversion warnings Coverity warns about the risk of unintended sign-exension in some of the calculations in spmi_arb.c. While the actual numbers used are small enough that this cannot happen in practice, it's still a good idea to clean them up by explicitly making the constants used unsigned. Signed-off-by: Julius Werner Change-Id: Ia169e0f7c6b01b8041e8029e8c8d30ee596ba30d --- plat/qti/common/src/spmi_arb.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/plat/qti/common/src/spmi_arb.c b/plat/qti/common/src/spmi_arb.c index 81cc57729..16e85a6fc 100644 --- a/plat/qti/common/src/spmi_arb.c +++ b/plat/qti/common/src/spmi_arb.c @@ -10,17 +10,17 @@ #include -#define REG_APID_MAP(apid) (0x0C440900 + 4 * i) +#define REG_APID_MAP(apid) (0x0C440900U + 4U * i) #define NUM_APID 0x80 -#define PPID_MASK (0xfff << 8) +#define PPID_MASK (0xfffU << 8) -#define REG_ARB_CMD(apid) (0x0C600000 + 0x10000 * apid) +#define REG_ARB_CMD(apid) (0x0C600000U + 0x10000U * apid) /* These are opcodes specific to this SPMI arbitrator, *not* SPMI commands. */ #define OPC_EXT_WRITEL 0 #define OPC_EXT_READL 1 -#define REG_ARB_STATUS(apid) (0x0C600008 + 0x10000 * apid) +#define REG_ARB_STATUS(apid) (0x0C600008U + 0x10000U * apid) #define ARB_STATUS_DONE BIT(0) #define ARB_STATUS_FAILURE BIT(1) #define ARB_STATUS_DENIED BIT(2) @@ -29,8 +29,8 @@ /* Fake status to report driver errors. */ #define ARB_FAKE_STATUS_TIMEOUT BIT(8) -#define REG_ARB_RDATA0(apid) (0x0C600018 + 0x10000 * apid) -#define REG_ARB_WDATA0(apid) (0x0C600010 + 0x10000 * apid) +#define REG_ARB_RDATA0(apid) (0x0C600018U + 0x10000U * apid) +#define REG_ARB_WDATA0(apid) (0x0C600010U + 0x10000U * apid) static int addr_to_apid(uint32_t addr) {