mirror of
https://gitlab.alpinelinux.org/alpine/aports.git
synced 2025-11-04 10:21:36 +01:00
46 lines
1.8 KiB
Diff
46 lines
1.8 KiB
Diff
Patch-Source: https://sourceforge.net/p/ecasound/bugs/54/attachment/0001-ecasignalview.cpp-always-use-s-style-format-for-prin.patch
|
|
--
|
|
From f2edef1f1e7b56f43ceea63f0d3024474f813b5d Mon Sep 17 00:00:00 2001
|
|
From: Sergei Trofimovich <slyich@gmail.com>
|
|
Date: Fri, 5 Nov 2021 23:26:19 +0000
|
|
Subject: [PATCH] ecasignalview.cpp: always use "%s"-style format for
|
|
printf()-style functions
|
|
|
|
`ncuses-6.3` added printf-style function attributes and now makes
|
|
it easier to catch cases when user input is used in palce of format
|
|
string when built with CFLAGS=-Werror=format-security:
|
|
|
|
ecasignalview.cpp:360:13:
|
|
error: format not a string literal and no format arguments [-Werror=format-security]
|
|
360 | mvprintw(r++, 0, bar);
|
|
| ~~~~~~~~^~~~~~~~~~~~~
|
|
|
|
Let's wrap all the missing places with "%s" format.
|
|
---
|
|
ecatools/ecasignalview.cpp | 4 ++--
|
|
1 file changed, 2 insertions(+), 2 deletions(-)
|
|
|
|
diff --git a/ecatools/ecasignalview.cpp b/ecatools/ecasignalview.cpp
|
|
index ea56a138..7f3b765b 100644
|
|
--- a/ecatools/ecasignalview.cpp
|
|
+++ b/ecatools/ecasignalview.cpp
|
|
@@ -351,13 +351,13 @@ void ecasv_output_init(void)
|
|
ecasv_rate_msec, ecasv_buffersize, avg_length); */
|
|
++r;
|
|
const char* bar="------------------------------------------------------------------------------\n";
|
|
- mvprintw(r++, 0, bar);
|
|
+ mvprintw(r++, 0, "%s", bar);
|
|
mvprintw(r, 0, "channel");
|
|
if (ecasv_log_display_mode)
|
|
mvprintw(r++,38, "%s avg-peak dB max-peak dB clipped\n", ecasv_bar_buffer);
|
|
else
|
|
mvprintw(r++,38, "%s avg-peak max-peak clipped\n", ecasv_bar_buffer);
|
|
- mvprintw(r++, 0, bar);
|
|
+ mvprintw(r++, 0, "%s", bar);
|
|
|
|
memset(ecasv_bar_buffer, ' ', ecasv_bar_length_const - 4);
|
|
ecasv_bar_buffer[ecasv_bar_length_const - 4] = 0;
|
|
--
|
|
2.33.1
|
|
|