mirror of
https://gitlab.alpinelinux.org/alpine/aports.git
synced 2026-01-22 17:13:27 +01:00
- I think it would be nice if we keep using similar function format (curly brackets) - Don't use curly brackets in variables if not needed - Don't overuse variables. If the value doesn't change just use the value. - Proper use of $pkgver in url. (not nitpicking but an actual bug) - break after 80 chars. - don't uses extra line breaks in shell lists when not needed. - Don't cleanup directories which are already in the base system - Test are disabled due to qemu, but we are not running qemu in our environment. tests are not portable so disable them. - examples are already inside the doc path, so i guess we can just ship them with doc subpackage - doc subpkg function doesn't need to be overridden. - libc6-compat should almost be never used in apkbuild. it probable means something is broken or incorrect