- I think it would be nice if we keep using similar function format
(curly brackets)
- Don't use curly brackets in variables if not needed
- Don't overuse variables. If the value doesn't change just use the
value.
- Proper use of $pkgver in url. (not nitpicking but an actual bug)
- break after 80 chars.
- don't uses extra line breaks in shell lists when not needed.
- Don't cleanup directories which are already in the base system
- Test are disabled due to qemu, but we are not running qemu in our
environment. tests are not portable so disable them.
- examples are already inside the doc path, so i guess we can just ship
them with doc subpackage
- doc subpkg function doesn't need to be overridden.
- libc6-compat should almost be never used in apkbuild. it probable means
something is broken or incorrect
One test fails on the builders because it relies on a tty being present.
Upstream has fixed this test to not rely on a tty anymore, but this has
not been released yet.
Apply the commit from upstream as a patch until a new version has been
released.
The previous patch to fix it does not work, so remove it.
- 4.1 was the first release to have a dependency upon ruamel.yaml
- List all dependencies explicitly to match setup.cfg [1]
- Stop using a parameter expansion that is not in POSIX: ${:0:1}
- Switch to running the full test suite
- setuptools is a runtime dependency because /usr/bin/ansible-lint
uses 'from pkg_resources import load_entry_point'
[1]: https://github.com/ansible/ansible-lint/blob/v4.1.0/setup.cfg#L82
- Switch to auto generated BitBucket source archive as the author
doesn't want to include the test suite in release artifacts [1]
- Run test suite in check() with 6 of c. 350 disabled because they are
run in a temporary folder and fail without the package installed
- Allow abuild to autodetect python3
- Python 3 only package so doesn't provide or replace Python 2 packages
[1] https://bitbucket.org/ruamel/yaml/issues/17/test-roundtrippy-absent-from-release#comment-24925407
