This is the same memcpy()-in-hot-path xxHash problem as described
in community/xxhash commit message.
The bug makes "zstd -1" or "zstd -t" ~15% slower on x86_64 though
higher levels (>= 9) are almost unaffected.
Other aport changes:
- make sure zlib/lzma/lz4 support is not compiled in automatically
(status quo, just make it explicit);
- re-enable armv7 since it is certainly well-supported by upstream,
was disabled by some script in the first place and should not be
affected by "Bus error" (i.e. some alignment problem) mentioned in
commit 2bae66907...
- use faster and shorter "make check" (unlike extensive "make test")
on arm* builders.
Yes, it is 20 times slower on x86* than it should be because xxhash.c always
uses "safe" memcpy()-based methods for unaligned memory access (XXH_readXX)
irregardless of input alignment due to x86-default XXH_FORCE_ALIGN_CHECK=0.
This ends up with real memcpy() calls in hot path (with -O2 too).
The bug affects Alpine x86* (not just edge, but at least 3.8 too -- i.e. this
is not something introduced in 0.6.5) for aligned and unaligned inputs. Other
architectures are severely affected for unaligned inputs only.
The fix lifts the XXH_FORCE_MEMORY_ACCESS=1 condition to enable XXH_readXX
methods based on __attribute__((__packed__)) usage everywhere except ARMv6
(which is covered by its own case earlier).
This is safe and fast because the compiler will either:
- use direct storage access instructions on capable architectures such as
aarch64, armv7, ppc64le, s390x, x86* irregardless of input alignment;
- or use relatively fast LWL/LWR instructions on mips* with unaligned input;
- or use byte load/stores and shifts/ors on armel with unaligned input which
is still faster then memcpy() call.
All aports that use xxhash.c are likely affected. For example, community/zstd
suffers too though not so grave (~15% difference for "zstd -t" on big archive)
and main/lz4 is twice slower on basic compression levels.
Other aport changes:
- modernize;
- enable check(); it is short and fast so suitable for slow builders too.
The python part is left intact though newer version exists.
./configure tries to update CFLAGS/LIBS with LIBNL3_CFLAGS/LIBS using '+=':
checking for LIBNL3... yes
./configure: line 14545: CFLAGS+= -I/usr/include/libnl3 : not found
./configure: line 14546: LIBS+= -lnl-genl-3 -lnl-3 : not found
so later build fails without proper libnl3 flags:
nbd-client.c:51:10: fatal error: netlink/netlink.h: No such file or directory
#include <netlink/netlink.h>
nbd-3.18 suffers from the same problem.
Build fails at switch_mips_unix.h with "$fp cannot be used in asm here"
because of forced -O0 (thus without -fomit-frame-pointer) in APKBUILD.
As a quick fix, use the "normal" C*FLAGS on mips* only. Test still
passes on mipsel at least.
Use the generic gcc/clang/suncc __BYTE_ORDER__ macro to detect platform
byte order instead of hard-coded architecture detection which is wrong
for ppc64le (always assumes POWER is big-endian) and lacks any knowledge
of mips*.
This change covers s390x too so remove s390x-support.patch.
Let build continue when git is not found. No changes in behaviour
because all attempts to use git (to get project revision etc) fail
due to missing .git folder in the source tarball and project falls
back to appversion.default in any case.
On edge check() fails with the following message:
make[3]: Entering directory '/home/room/aports/community/libfm/src/libfm-1.3.0.2/src/tests'
make check-local
make[4]: Entering directory '/home/room/aports/community/libfm/src/libfm-1.3.0.2/src/tests'
TEST: fm-path... (pid=28635)
** (process:28635): WARNING **: 11:58:23.519: The directory '~/Templates' doesn't exist, ignoring it
Tests were compiled with G_DISABLE_ASSERT and are likely no-ops. Aborting.
FAIL: fm-path
The message is printed by the g_test_init() macro from glib-2.0/glib/gtestutils.h
because src/tests/test-fm-path.c #undef's G_DISABLE_ASSERT too late. Move #undef
earlier in the code to fix the problem and make test pass on x86_64 and mipsel at
least.
The archive download link gives tarball with a wrong checksum so
use the 7.0.3 download link from the greenbone/gvmd Releases page:
https://github.com/greenbone/gvmd/releases
