main/libcddb: modernise, fix license, broken tests

main/libcddb/APKBUILD

@@ -2,40 +2,39 @@
 # Maintainer:
 pkgname=libcddb
 pkgver=1.3.2
-pkgrel=2
+pkgrel=3
 pkgdesc="Library that implements the different protocols (CDDBP, HTTP, SMTP) to access data on a CDDB server (e.g. http://freedb.org)."
 url="https://sourceforge.net/projects/libcddb/"
 arch="all"
-license="GPL"
+options="!check"  # Tests are known broken since 2009:
+# https://sourceforge.net/p/libcddb/bugs/7/
+license="LGPL-2.0+"
 depends=
 makedepends=
 install=
 subpackages="$pkgname-dev"
 source="http://downloads.sourceforge.net/$pkgname/$pkgname-$pkgver.tar.bz2"
 
-_builddir="$srcdir"/$pkgname-$pkgver
-
 prepare() {
-	cd "$_builddir"
-	update_config_sub || return 1
-	# apply patches here
+	cd "$builddir"
+	update_config_sub
+	default_prepare
 }
 
 build() {
-	cd "$_builddir"
+	cd "$builddir"
 	./configure \
 		--build=$CBUILD \
 		--host=$CHOST \
 		--prefix=/usr \
 		--sysconfdir=/etc \
 		--mandir=/usr/share/man \
-		--infodir=/usr/share/info \
-		|| return 1
-	make || return 1
+		--infodir=/usr/share/info
+	make
 }
 
 package() {
-	cd "$_builddir"
+	cd "$builddir"
 	make DESTDIR="$pkgdir" install
 }