From 51e4fc6fdcac475e81417ffd078e052a7f3f5cb2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=B6ren=20Tempel?= Date: Sun, 6 Jun 2021 12:18:13 +0200 Subject: [PATCH] main/alsa-lib: enable asserts again The `--without-debug` flag was added silently in e7099738bf1b128a096ef96db35bb6a7d01eda69. As per `./configure --help`, this flag disable assert statements in alsa-lib. This is undesirable since it makes library usage errors more laborious to debug or potentially even makes them go unnoticed. For example, see #12729 where a null pointer was passed to snd_config_delete by alsa-utils. While the snd_config_delete function in alsa-lib contains an assert checking that the passed config is non-null this assert was disabled due to the aforementioned configure flag. See also: * https://lists.alpinelinux.org/~alpine/devel/%3C1ZU8S8ERRPKR9.35CUIBSS8QET7%408pit.net%3E --- main/alsa-lib/APKBUILD | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/main/alsa-lib/APKBUILD b/main/alsa-lib/APKBUILD index d991ce00318..f72986d0f38 100644 --- a/main/alsa-lib/APKBUILD +++ b/main/alsa-lib/APKBUILD @@ -1,7 +1,7 @@ # Maintainer: Natanael Copa pkgname=alsa-lib pkgver=1.2.5 -pkgrel=1 +pkgrel=2 pkgdesc="Advanced Linux Sound Architecture (ALSA) library" url="http://www.alsa-project.org" arch="all" @@ -27,7 +27,6 @@ build() { --enable-rawmidi \ --enable-seq \ --enable-aload \ - --without-debug \ --disable-dependency-tracking \ --without-versioned make