mirror of
https://github.com/comfyanonymous/ComfyUI.git
synced 2026-04-16 20:51:16 +02:00
Add --feature-flag KEY=VALUE CLI argument that allows setting arbitrary server feature flags at startup. Values are auto-converted to appropriate Python types (bool, int, float, string). CLI flags are merged into SERVER_FEATURE_FLAGS but cannot overwrite core flags. Add --list-feature-flags which prints the registry of known CLI-settable feature flags as JSON and exits, enabling launchers to discover valid flags for a specific ComfyUI version. Part of Comfy-Org/ComfyUI-Desktop-2.0-Beta#415 Co-authored-by: Amp <amp@ampcode.com> Amp-Thread-ID: https://ampcode.com/threads/T-019d9386-54d3-74d9-a661-97e0a8d37b6b
132 lines
3.7 KiB
Python
132 lines
3.7 KiB
Python
"""
|
|
Feature flags module for ComfyUI WebSocket protocol negotiation.
|
|
|
|
This module handles capability negotiation between frontend and backend,
|
|
allowing graceful protocol evolution while maintaining backward compatibility.
|
|
"""
|
|
|
|
from typing import Any, TypedDict
|
|
|
|
from comfy.cli_args import args
|
|
|
|
|
|
class FeatureFlagInfo(TypedDict):
|
|
type: str
|
|
default: Any
|
|
description: str
|
|
|
|
|
|
# Registry of known CLI-settable feature flags.
|
|
# Launchers can query this via --list-feature-flags to discover valid flags.
|
|
CLI_FEATURE_FLAG_REGISTRY: dict[str, FeatureFlagInfo] = {
|
|
"show_signin_button": {
|
|
"type": "bool",
|
|
"default": False,
|
|
"description": "Show the sign-in button in the frontend even when not signed in",
|
|
},
|
|
}
|
|
|
|
|
|
def get_cli_feature_flag_registry() -> dict[str, FeatureFlagInfo]:
|
|
"""Return the registry of known CLI-settable feature flags."""
|
|
return {k: dict(v) for k, v in CLI_FEATURE_FLAG_REGISTRY.items()}
|
|
|
|
|
|
_COERCE_FNS: dict[str, Any] = {
|
|
"bool": lambda v: v.lower() == "true",
|
|
"int": lambda v: int(v),
|
|
"float": lambda v: float(v),
|
|
}
|
|
|
|
|
|
def _coerce_flag_value(key: str, raw_value: str) -> Any:
|
|
"""Coerce a raw string value using the registry type, or keep as string."""
|
|
info = CLI_FEATURE_FLAG_REGISTRY.get(key)
|
|
if info is None:
|
|
return raw_value
|
|
coerce = _COERCE_FNS.get(info["type"])
|
|
if coerce is None:
|
|
return raw_value
|
|
return coerce(raw_value)
|
|
|
|
|
|
def _parse_cli_feature_flags() -> dict[str, Any]:
|
|
"""Parse --feature-flag key=value pairs from CLI args into a dict."""
|
|
result: dict[str, Any] = {}
|
|
for item in getattr(args, "feature_flag", []):
|
|
if "=" not in item:
|
|
continue
|
|
key, _, raw_value = item.partition("=")
|
|
key = key.strip()
|
|
if key:
|
|
result[key] = _coerce_flag_value(key, raw_value.strip())
|
|
return result
|
|
|
|
|
|
# Default server capabilities
|
|
_CORE_FEATURE_FLAGS: dict[str, Any] = {
|
|
"supports_preview_metadata": True,
|
|
"max_upload_size": args.max_upload_size * 1024 * 1024, # Convert MB to bytes
|
|
"extension": {"manager": {"supports_v4": True}},
|
|
"node_replacements": True,
|
|
"assets": args.enable_assets,
|
|
}
|
|
|
|
# CLI-provided flags cannot overwrite core flags
|
|
_cli_flags = {k: v for k, v in _parse_cli_feature_flags().items() if k not in _CORE_FEATURE_FLAGS}
|
|
|
|
SERVER_FEATURE_FLAGS: dict[str, Any] = {**_CORE_FEATURE_FLAGS, **_cli_flags}
|
|
|
|
|
|
def get_connection_feature(
|
|
sockets_metadata: dict[str, dict[str, Any]],
|
|
sid: str,
|
|
feature_name: str,
|
|
default: Any = False
|
|
) -> Any:
|
|
"""
|
|
Get a feature flag value for a specific connection.
|
|
|
|
Args:
|
|
sockets_metadata: Dictionary of socket metadata
|
|
sid: Session ID of the connection
|
|
feature_name: Name of the feature to check
|
|
default: Default value if feature not found
|
|
|
|
Returns:
|
|
Feature value or default if not found
|
|
"""
|
|
if sid not in sockets_metadata:
|
|
return default
|
|
|
|
return sockets_metadata[sid].get("feature_flags", {}).get(feature_name, default)
|
|
|
|
|
|
def supports_feature(
|
|
sockets_metadata: dict[str, dict[str, Any]],
|
|
sid: str,
|
|
feature_name: str
|
|
) -> bool:
|
|
"""
|
|
Check if a connection supports a specific feature.
|
|
|
|
Args:
|
|
sockets_metadata: Dictionary of socket metadata
|
|
sid: Session ID of the connection
|
|
feature_name: Name of the feature to check
|
|
|
|
Returns:
|
|
Boolean indicating if feature is supported
|
|
"""
|
|
return get_connection_feature(sockets_metadata, sid, feature_name, False) is True
|
|
|
|
|
|
def get_server_features() -> dict[str, Any]:
|
|
"""
|
|
Get the server's feature flags.
|
|
|
|
Returns:
|
|
Dictionary of server feature flags
|
|
"""
|
|
return SERVER_FEATURE_FLAGS.copy()
|